Fix ProductionBar visually glitching for units without value#21088
Merged
Conversation
Contributor
|
How about use time instead of cost? We also have |
PunkPun
reviewed
Oct 9, 2023
| if (current == null) | ||
| value = 0; | ||
| else if (current.TotalCost <= 0) | ||
| value = 1; |
Member
Author
There was a problem hiding this comment.
No, the unit will be produced instantly so we want to display a full bar.
Setting the value to one displays the bar correctly as full for the split second the unit is build.
PunkPun
approved these changes
Oct 11, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a unit buildable for testing purposes without giving them a cost/value. (The default for
Valued.Costeven is zero.) That caused the production bar in TS to glitch to the bottom left for a brief second. Setting the value to one displays the bar correctly as full for the split second the unit is build.