Automate documentation website updates#21130
Merged
PunkPun merged 3 commits intoOpenRA:bleedfrom Nov 20, 2023
Merged
Conversation
RoosterDragon
approved these changes
Oct 21, 2023
Member
RoosterDragon
left a comment
There was a problem hiding this comment.
No complaints about automating this. Will trust that you've got the workflow to run cleanly for this.
Member
|
Typo in the second commit message. You can also squash them. |
32984a2 to
b92485a
Compare
Member
Author
|
Fixed the typo and rebased for good measure. I went through the deliberate effort of splitting it into two commits so I don't really want to squish them. I think reviewing then with |
Member
Member
Author
|
Apparently having an environment variable called "VERSION" can have horrible consequences: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, the documentation website relies on manually running the workflow to update it and inputting the correct version. This is now automated on tagging a release or playtest.
The other thing here is that now merges to the
bleedbranch will trigger the workflow, which will try to update the dev version of the documentation website to always keep it up-to-date.