Skip to content

Automate documentation website updates#21130

Merged
PunkPun merged 3 commits intoOpenRA:bleedfrom
penev92:automateDocumentation
Nov 20, 2023
Merged

Automate documentation website updates#21130
PunkPun merged 3 commits intoOpenRA:bleedfrom
penev92:automateDocumentation

Conversation

@penev92
Copy link
Copy Markdown
Member

@penev92 penev92 commented Oct 17, 2023

So far, the documentation website relies on manually running the workflow to update it and inputting the correct version. This is now automated on tagging a release or playtest.
The other thing here is that now merges to the bleed branch will trigger the workflow, which will try to update the dev version of the documentation website to always keep it up-to-date.

Copy link
Copy Markdown
Member

@RoosterDragon RoosterDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complaints about automating this. Will trust that you've got the workflow to run cleanly for this.

@Mailaender
Copy link
Copy Markdown
Member

Typo in the second commit message. You can also squash them.

@penev92
Copy link
Copy Markdown
Member Author

penev92 commented Nov 3, 2023

Fixed the typo and rebased for good measure. I went through the deliberate effort of splitting it into two commits so I don't really want to squish them. I think reviewing then with ?w=1 makes it very easy to see what's going on in each one.

Copy link
Copy Markdown
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a spin

@PunkPun PunkPun merged commit 59ad9e3 into OpenRA:bleed Nov 20, 2023
@PunkPun
Copy link
Copy Markdown
Member

PunkPun commented Nov 20, 2023

Changelog

@penev92
Copy link
Copy Markdown
Member Author

penev92 commented Nov 21, 2023

Apparently having an environment variable called "VERSION" can have horrible consequences:
https://github.com/OpenRA/OpenRA/actions/runs/6931226699/job/18852517817
The cause is explained here: dotnet/msbuild#2713
Also I did a derp on the wiki job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants