Skip to content

Those trait should work only when in world as well#21131

Merged
Mailaender merged 2 commits into
OpenRA:bleedfrom
dnqbob:isinworldf
Oct 21, 2023
Merged

Those trait should work only when in world as well#21131
Mailaender merged 2 commits into
OpenRA:bleedfrom
dnqbob:isinworldf

Conversation

@dnqbob

@dnqbob dnqbob commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@Mailaender

Copy link
Copy Markdown
Member

I think this is redundant because ITick is invoked in World and only for actors in world. I also didn't notice any rendering changes for the Red Alert crate drop plane. It will stop rendering trails here and on bleed when leaving the map.

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though the trails still act incorrectly when a unit is exiting a transport. The first trail is placed where the unit entered the transport rather than its current position where it is exiting

@PunkPun

PunkPun commented Oct 21, 2023

Copy link
Copy Markdown
Member

@Mailaender this fixes a visual glitch where when a carryall would pickup a damaged harvester the smoke would remain on the ground in the position the harvester was picked from

@dnqbob

dnqbob commented Oct 21, 2023

Copy link
Copy Markdown
Contributor Author

also didn't notice any rendering changes for the Red Alert crate drop plane

@Mailaender The LeavesTrails is not Contrail, I guess you mean Contrail but it is not fixed in this PR.

@dnqbob

dnqbob commented Oct 21, 2023

Copy link
Copy Markdown
Contributor Author

I think this is redundant because ITick is invoked in World and only for actors in world.

ITick still run for those not in world.
bug

@Mailaender Mailaender merged commit 8b96b75 into OpenRA:bleed Oct 21, 2023
@Mailaender

Copy link
Copy Markdown
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants