Render Chrono Vortex using a shader effect#21148
Merged
Merged
Conversation
bbdaf4b to
38d8cf9
Compare
PunkPun
reviewed
Oct 23, 2023
PunkPun
left a comment
Member
There was a problem hiding this comment.
This will need an update rule, and I don't think it closes that issue just yet
123717a to
24f177c
Compare
Member
Author
|
Updated. |
7a5446b to
e582fab
Compare
Contributor
|
Will this also twist the renderable comes from |
Contributor
|
And I got this crash in current branch test, using ANGLE and Windowed. and |
Member
Author
No. |
dnqbob
reviewed
Oct 26, 2023
e582fab to
e0eaa4f
Compare
Member
Author
|
Updated. |
Contributor
|
Test on ANGLE and Modern in FullScreen and Windowed is OK. My PC cannot properly run Embedded GL so I cannot give the final conclusion of the test. Is there someone can help to test on Embedded GL? |
PunkPun
approved these changes
Oct 27, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9778.