Skip to content

Render Chrono Vortex using a shader effect#21148

Merged
PunkPun merged 2 commits into
OpenRA:bleedfrom
pchote:chrono-vortex-renderer
Oct 27, 2023
Merged

Render Chrono Vortex using a shader effect#21148
PunkPun merged 2 commits into
OpenRA:bleedfrom
pchote:chrono-vortex-renderer

Conversation

@pchote

@pchote pchote commented Oct 23, 2023

Copy link
Copy Markdown
Member

Closes #9778.

@pchote pchote force-pushed the chrono-vortex-renderer branch 2 times, most recently from bbdaf4b to 38d8cf9 Compare October 23, 2023 20:27

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need an update rule, and I don't think it closes that issue just yet

Comment thread glsl/postprocess_textured.vert Outdated
@pchote pchote force-pushed the chrono-vortex-renderer branch 2 times, most recently from 123717a to 24f177c Compare October 24, 2023 19:57
@pchote

pchote commented Oct 24, 2023

Copy link
Copy Markdown
Member Author

Updated.

@pchote pchote force-pushed the chrono-vortex-renderer branch 2 times, most recently from 7a5446b to e582fab Compare October 25, 2023 10:17
@dnqbob

dnqbob commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

Will this also twist the renderable comes from ISelectionDecorations or selection bar or bound visually?

@dnqbob

dnqbob commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

And I got this crash in current branch test, using ANGLE and Windowed.

Exception of type `System.InvalidOperationException`: OpenGL Error: See graphics.log for details.
   at OpenRA.Platforms.Default.OpenGL.DebugMessageHandler(Int32 source, Int32 type, UInt32 id, Int32 severity, Int32 length, StringBuilder message, IntPtr userparam) in D:\work\Projects\Github\OpenRA\OpenRA.Platforms.Default\OpenGL.cs:line 765
   at OpenRA.Platforms.Default.Sdl2GraphicsContext.DrawPrimitives(PrimitiveType pt, Int32 firstVertex, Int32 numVertices) in D:\work\Projects\Github\OpenRA\OpenRA.Platforms.Default\Sdl2GraphicsContext.cs:line 157
   at OpenRA.Renderer.DrawBatch[T](IVertexBuffer`1 vertices, IShader shader, Int32 firstVertex, Int32 numVertices, PrimitiveType type) in D:\work\Projects\Github\OpenRA\OpenRA.Game\Renderer.cs:line 340
   at OpenRA.Mods.Cnc.Traits.ChronoVortexRenderer.OpenRA.Traits.IRenderPostProcessPass.Draw(WorldRenderer wr, ITexture worldTexture) in D:\work\Projects\Github\OpenRA\OpenRA.Mods.Cnc\Traits\World\ChronoVortexRenderer.cs:line 103
   at OpenRA.Graphics.WorldRenderer.ApplyPostProcessing(PostProcessPassType type) in D:\work\Projects\Github\OpenRA\OpenRA.Game\Graphics\WorldRenderer.cs:line 337
   at OpenRA.Graphics.WorldRenderer.Draw() in D:\work\Projects\Github\OpenRA\OpenRA.Game\Graphics\WorldRenderer.cs:line 304
   at OpenRA.Game.RenderTick() in D:\work\Projects\Github\OpenRA\OpenRA.Game\Game.cs:line 729
   ...

and

High - GL Debug API Output: Error - Cannot have negative start.
   at OpenRA.Platforms.Default.OpenGL.BuildErrorText(Int32 source, Int32 type, Int32 severity, StringBuilder message)
   at OpenRA.Platforms.Default.OpenGL.DebugMessageHandler(Int32 source, Int32 type, UInt32 id, Int32 severity, Int32 length, StringBuilder message, IntPtr userparam)
   at OpenRA.Platforms.Default.Sdl2GraphicsContext.DrawPrimitives(PrimitiveType pt, Int32 firstVertex, Int32 numVertices)
   at OpenRA.Renderer.DrawBatch[T](IVertexBuffer`1 vertices, IShader shader, Int32 firstVertex, Int32 numVertices, PrimitiveType type)
   at OpenRA.Mods.Cnc.Traits.ChronoVortexRenderer.OpenRA.Traits.IRenderPostProcessPass.Draw(WorldRenderer wr, ITexture worldTexture)
   at OpenRA.Graphics.WorldRenderer.ApplyPostProcessing(PostProcessPassType type)
   at OpenRA.Graphics.WorldRenderer.Draw()
   at OpenRA.Game.RenderTick()
   at OpenRA.Game.Loop()
   at OpenRA.Game.Run()
   at OpenRA.Game.InitializeAndRun(String[] args)
   at OpenRA.Launcher.Program.Main(String[] args)

OpenGL Information:
Vendor: Google Inc. (Intel)
Renderer: ANGLE (Intel, Intel(R) UHD Graphics Direct3D11 vs_5_0 ps_5_0, D3D11-30.0.101.1122)
GL Version: OpenGL ES 3.0.0 (ANGLE 2.1.20989 git hash: 5c0b4251bd2c)
Shader Version: OpenGL ES GLSL ES 3.00 (ANGLE 2.1.20989 git hash: 5c0b4251bd2c)

@pchote

pchote commented Oct 25, 2023

Copy link
Copy Markdown
Member Author

Will this also twist the renderable comes from ISelectionDecorations or selection bar or bound visually?

No.

Comment thread OpenRA.Mods.Cnc/Traits/World/ChronoVortexRenderer.cs
@pchote

pchote commented Oct 26, 2023

Copy link
Copy Markdown
Member Author

Updated.

@dnqbob

dnqbob commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

Test on ANGLE and Modern in FullScreen and Windowed is OK.

My PC cannot properly run Embedded GL so I cannot give the final conclusion of the test.

Is there someone can help to test on Embedded GL?

@PunkPun PunkPun merged commit 37ce5e4 into OpenRA:bleed Oct 27, 2023
@PunkPun

PunkPun commented Oct 27, 2023

Copy link
Copy Markdown
Member

Changelog

@pchote pchote deleted the chrono-vortex-renderer branch October 29, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chrono vortex

3 participants