Increase sound source pool size to the maximum#21174
Merged
Merged
Conversation
abcdefg30
reviewed
Oct 30, 2023
PunkPun
force-pushed
the
fix-sound
branch
2 times, most recently
from
3649675 to
91381c3
Compare
pchote
reviewed
Oct 30, 2023
PunkPun
force-pushed
the
fix-sound
branch
2 times, most recently
from
c0e73c7 to
670ec03
Compare
PunkPun
changed the title
pchote
approved these changes
Oct 30, 2023
abcdefg30
approved these changes
Oct 30, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19724
kcat/openal-soft#580
https://github.com/kcat/openal-soft/blob/b6aa73b26004afe63d83097f2f91ecda9bc25cb9/alc/alc.cpp#L1468-L1485
https://github.com/kcat/openal-soft/blob/b6aa73b26004afe63d83097f2f91ecda9bc25cb9/alc/alc.cpp#L3191-L3203
If I try to create a 257th source it errors with
with the AL error being