Fix a collection of issues reported by analyzers of VS2022#21175
Merged
Conversation
This method only every receives a list as parameter
The info is already set with the same name in the constructor
PunkPun
reviewed
Oct 30, 2023
| } | ||
|
|
||
| public static IEnumerable<Order> ClearBlockersOrders(IEnumerable<CPos> tiles, Player owner, Actor ignoreActor = null) | ||
| public static IEnumerable<Order> ClearBlockersOrders(List<CPos> tiles, Player owner, Actor ignoreActor = null) |
Member
There was a problem hiding this comment.
Suggested change
| public static IEnumerable<Order> ClearBlockersOrders(List<CPos> tiles, Player owner, Actor ignoreActor = null) | |
| public static IEnumerable<Order> ClearBlockersOrders(ICollection<CPos> tiles, Player owner, Actor ignoreActor = null) |
perhaps this?
PunkPun
approved these changes
Oct 30, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #21013 I ran the analyzer on the entire solution again and a few warnings came up that I thought we already fixed and enforced (like the multiple enumerations warning in AIUtils). This PR fixes the warnings I came across.