Task #20918 (Improve PNG filesize on save)#21225
Conversation
|
Extra unit tests are great, no issues with that. For the commits, you might find the following useful to condense your changes into a single commit, and for updating the commit message. We would usually ask that the commit message is something that describes the change.
As both of those questions note, you will need to force push those changes, so that your PR is updated. Thanks for your contribution. |
Done |
abcdefg30
left a comment
There was a problem hiding this comment.
Code changes seem simple enough. 👍 Some minor/style nits.
|
Ping, should the PR be taken over? |
Comments removing update3
PunkPun
left a comment
There was a problem hiding this comment.
Force pushed fixes to style violations. LGTM
Hi, I was working on task: #20918
I little changed Save method for 8bbp, 24bbp and alpha channel. I hope it is good. I added DeflaterOutputStream with max compression.
I add some unit tests too. I know it was not in the task, but I am doing it as a school task and we had to add some tests, so I hope It is not a big problem. If it is, I can remove them.
PS: I am sorry for git messages. I read conditions too late.