Skip to content

Task #20918 (Improve PNG filesize on save)#21225

Merged
PunkPun merged 1 commit into
OpenRA:bleedfrom
Bujacikk:bleed
Jan 7, 2024
Merged

Task #20918 (Improve PNG filesize on save)#21225
PunkPun merged 1 commit into
OpenRA:bleedfrom
Bujacikk:bleed

Conversation

@Bujacikk

@Bujacikk Bujacikk commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

Hi, I was working on task: #20918

I little changed Save method for 8bbp, 24bbp and alpha channel. I hope it is good. I added DeflaterOutputStream with max compression.
I add some unit tests too. I know it was not in the task, but I am doing it as a school task and we had to add some tests, so I hope It is not a big problem. If it is, I can remove them.

PS: I am sorry for git messages. I read conditions too late.

@RoosterDragon

Copy link
Copy Markdown
Member

Extra unit tests are great, no issues with that.

For the commits, you might find the following useful to condense your changes into a single commit, and for updating the commit message. We would usually ask that the commit message is something that describes the change.

As both of those questions note, you will need to force push those changes, so that your PR is updated.

Thanks for your contribution.

@Bujacikk

Copy link
Copy Markdown
Contributor Author

Extra unit tests are great, no issues with that.

For the commits, you might find the following useful to condense your changes into a single commit, and for updating the commit message. We would usually ask that the commit message is something that describes the change.

As both of those questions note, you will need to force push those changes, so that your PR is updated.

Thanks for your contribution.

Done

@abcdefg30 abcdefg30 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes seem simple enough. 👍 Some minor/style nits.

Comment thread OpenRA.Game/FileFormats/Png.cs Outdated
Comment thread OpenRA.Test/OpenRA.Game/PngTest.cs Outdated
Comment thread OpenRA.Test/OpenRA.Game/PngTest.cs Outdated
Comment thread OpenRA.Test/OpenRA.Game/PngTest.cs Outdated
@PunkPun

PunkPun commented Dec 15, 2023

Copy link
Copy Markdown
Member

Ping, should the PR be taken over?

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force pushed fixes to style violations. LGTM

@PunkPun
PunkPun merged commit 0741439 into OpenRA:bleed Jan 7, 2024
@PunkPun

PunkPun commented Jan 7, 2024

Copy link
Copy Markdown
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants