implements flashing on healing units#21269
Conversation
| Warhead@1Dam: TargetDamage | ||
| ValidTargets: Repair | ||
| Warhead@2Eff: FlashTargetsInRadius | ||
| ValidTargets: Vehicle |
There was a problem hiding this comment.
These don't seem right. Should they have matching ValidTargets?
There was a problem hiding this comment.
Not really, unless I reorder the warheads. Repair is condition based target for units with less than full hp. If first warhead heals to full then the second will not be valid
| ValidTargets: Heal | ||
| Warhead@2Eff: FlashTargetsInRadius | ||
| ValidTargets: Infantry | ||
| ValidRelationships: Ally |
There was a problem hiding this comment.
shouldn't the heal warhead then only heal allies as well?
There was a problem hiding this comment.
armaments have TargetRelationships: Ally so it's fine
edit: added validRelationships for consistency with RA
CDVoidwalker
force-pushed
the
flash-effect
branch
from
7d9ade2 to
c58c5f8
Compare
|
|
||
| namespace OpenRA.Mods.Common.Warheads | ||
| { | ||
| [Desc("Used to trigger a FlashPostProcessEffect trait on the world actor.")] |
There was a problem hiding this comment.
| [Desc("Used to trigger a FlashPostProcessEffect trait on the world actor.")] | |
| [Desc("Trigger a flash effect on the targeted actor, or actors within a circle.")] |
Was this a placeholder until you were clear on if the area effect should be split? If so, it can't hurt to have a comment as a reminder.
There was a problem hiding this comment.
Yeah I forgot about that part, thanks
CDVoidwalker
force-pushed
the
flash-effect
branch
from
c58c5f8 to
03e46a8
Compare
3 participants
Implements warhead that applies flashing effect to units in given area or target depending on properties. My only concern is that I was not sure which approach for area is correct and consistent with the project. It could very well be 2 different warheads with a lot of overlap (FlashesTargetsInRadius / FlashesTarget ) or this odd approach with radius that may be confusing for users.
Fixes #21068