Adds tilting on slopes to suitable actor previews#21271
Merged
Conversation
PunkPun
reviewed
Dec 27, 2023
PunkPun
left a comment
PunkPun
left a comment
Member
There was a problem hiding this comment.
This doesn't handle ramp changes. Cached values should not be completely static
PunkPun
reviewed
Dec 31, 2023
CDVoidwalker
force-pushed
the
actor-previews-tilting
branch
from
January 7, 2024 16:27
ef265d8 to
c1e7294
Compare
PunkPun
reviewed
Jan 8, 2024
CDVoidwalker
force-pushed
the
actor-previews-tilting
branch
from
January 8, 2024 11:13
c1e7294 to
dd608c9
Compare
PunkPun
force-pushed
the
actor-previews-tilting
branch
from
January 9, 2024 12:54
dd608c9 to
99c1e64
Compare
PunkPun
approved these changes
Jan 9, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more functionality to ActorPreview.cs. GetOrientation now checks for MobileInfo, and whether the actor has TerrainOrientationAdjustmentMargin defined. If so it gets orientation of the slope the actor is upon and applies facing rotation onto it. Otherwise the functionality remains unchanged. Tested new functionality on TS mod and saw no regressions on TD/RA end.
2023-12-23.19-44-24.mp4