Fetch the player name from itch.io#21285
Conversation
ab3b48a to
606f3fb
Compare
|
It might make sense to make this use an interface so that the discord module can implement it too? |
606f3fb to
62e956e
Compare
|
If the Discord API supports it, I will do that as a followup pull request. |
62e956e to
66df22d
Compare
abcdefg30
left a comment
There was a problem hiding this comment.
Codes changes lgtm so far.
If the Discord API supports it, I will do that as a followup pull request.
I think we need to/should add a ExternalNameProvider class which implements IGlobalModData, and that class can then calls the integrations for itch, Discord, etc. I'm ok with not changing this here though, it should be a simple enough change in IntroductionPromptLogic.
There DiscordRpcClient offers a way to get the display and user names of the current user, so DiscordService can return it (client.CurrentUser.Username/DisplayName).
|
Please don't even start extra threads if the api key is not set. |
This will be done on the threadpool, which is already created elsewhere in the code. So im pretty sure no new thread will be created in this case. |
66df22d to
78c8c85
Compare
Closes #14708