ParallelProductionQueue: pause production, when all Production traits are paused#21296
Merged
abcdefg30 merged 1 commit intoFeb 25, 2024
Merged
Conversation
anvilvapre
reviewed
Jan 15, 2024
Contributor
anvilvapre
left a comment
anvilvapre
left a comment
There was a problem hiding this comment.
The code from the Classic production queue is 'faster'.
Makes you wonder why this wasn't used before? Perhaps only used for classic initially?
michaeldgg2
force-pushed
the
ParallelProductionQueue-pausing
branch
from
29d10fe to
c253dfe
Compare
Contributor
Author
|
I believe this was bug made by mistake, when I added a test case for Hand of Nod and Barracks in ts. |
abcdefg30
force-pushed
the
ParallelProductionQueue-pausing
branch
from
c253dfe to
077aa9a
Compare
abcdefg30
approved these changes
Feb 25, 2024
Member
abcdefg30
left a comment
abcdefg30
left a comment
There was a problem hiding this comment.
Lgtm, removed the testcase.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion on Discord, this PR makes
ParallelProductionQueuesupport pausedProductiontraits (i.e. the production is actually paused).