Rename Explodes to FireWarheadOnDeath and ThrowsShrapnel to FireProjectilesOnDeath#21303
Merged
Conversation
Member
|
|
Member
Author
|
ah, then maybe though, it seems this trait can fire armament warheads? That feature seems not documented well |
Member
Author
|
ah, it just checks wether armaments are reloading? It feels like a weird addition by 807a40c |
PunkPun
changed the title
Member
|
That's because of 807a40c#diff-a07a0d9c278ea31728c92ecb796f0fcbdd67a8cdd78c8a4611a88c94bee1a4d2R134 Do you feel like fixing that here? |
Member
Author
|
6d0fbfa had removed the comment. #18202 (comment) |
abcdefg30
reviewed
Feb 7, 2024
abcdefg30
reviewed
Feb 7, 2024
abcdefg30
reviewed
Feb 7, 2024
abcdefg30
reviewed
Feb 7, 2024
PunkPun
force-pushed
the
rename
branch
2 times, most recently
from
February 7, 2024 15:08
5e6e52a to
a523a2c
Compare
abcdefg30
reviewed
Feb 9, 2024
abcdefg30
reviewed
Feb 9, 2024
PunkPun
changed the title
Member
Author
|
Also renamed |
Member
|
This has merge conflicts. |
abcdefg30
reviewed
Sep 19, 2024
abcdefg30
reviewed
Sep 19, 2024
abcdefg30
approved these changes
Sep 19, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are more fitting names
I also add missing descriptions to AirstrikePower and ParatroopersPower