Implement Stream.Read(Span<byte>) overloads.#21356
Merged
Merged
Conversation
The default Stream implementation of this method has to rent an array so it can call the overload that accepts an array, and then copy the output over. This is because the array overload is required and the span overload was only added more recently. We can avoid the overhead of this by implementing the span overload and working with the destination span directly. Do so for all classes we have that derive from Stream, and redirect their array overload to the span overload for code reuse.
pchote
approved these changes
Mar 9, 2024
pchote
left a comment
pchote
left a comment
Member
There was a problem hiding this comment.
Code changes LGTM, and tested that the 4 default mods all launch to the shellmap without problems.
PunkPun
approved these changes
Mar 11, 2024
PunkPun
left a comment
PunkPun
left a comment
Member
There was a problem hiding this comment.
I had also tested a bunch of formats, but didn't test videos yet
anvilvapre
approved these changes
Mar 25, 2024
| var conversion = (short)(floatBuffer[i] * 32767); | ||
| buffer[offset++] = (byte)(conversion & 255); | ||
| buffer[offset++] = (byte)(conversion >> 8); | ||
| buffer[i * 2 + 0] = (byte)(conversion & 255); |
Contributor
There was a problem hiding this comment.
Trivial. But slower. Would then store it in a temp var.
Contributor
|
Ping. Might as well merge this. Unless you still want to test videos. |
Member
|
I count two approvals, so merging. Tested locally that this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default Stream implementation of this method has to rent an array so it can call the overload that accepts an array, and then copy the output over. This is because the array overload is required and the span overload was only added more recently.
We can avoid the overhead of this by implementing the span overload and working with the destination span directly. Do so for all classes we have that derive from Stream, and redirect their array overload to the span overload for code reuse.