Skip to content

Avoid redundant and hard-coded support power cursors#21402

Merged
PunkPun merged 2 commits intoOpenRA:bleedfrom
Mailaender:support-power-cursors
May 19, 2024
Merged

Avoid redundant and hard-coded support power cursors#21402
PunkPun merged 2 commits intoOpenRA:bleedfrom
Mailaender:support-power-cursors

Conversation

@Mailaender
Copy link
Copy Markdown
Member

including some additional lint checking.

Comment thread OpenRA.Mods.Common/Traits/SupportPowers/AirstrikePower.cs Outdated
Comment thread OpenRA.Mods.Common/Traits/SupportPowers/ParatroopersPower.cs Outdated
@Mailaender Mailaender force-pushed the support-power-cursors branch from 60e9b67 to f7fe198 Compare April 14, 2024 16:00
Comment thread OpenRA.Mods.Common/UpdateRules/Rules/20231010/AddSpawnActorPowerBlockedCursor.cs Outdated
@Mailaender Mailaender force-pushed the support-power-cursors branch from f7fe198 to fdcaed5 Compare April 27, 2024 10:42
Copy link
Copy Markdown
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM but not tested.

Copy link
Copy Markdown
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Comment thread OpenRA.Mods.Common/UpdateRules/Rules/20231010/AddSpawnActorPowerBlockedCursor.cs Outdated
@Mailaender Mailaender force-pushed the support-power-cursors branch from 97be428 to 214d9c0 Compare May 4, 2024 12:05
Copy link
Copy Markdown
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit 69d9bbb into OpenRA:bleed May 19, 2024
@PunkPun
Copy link
Copy Markdown
Member

PunkPun commented May 19, 2024

changelog

@Mailaender Mailaender deleted the support-power-cursors branch May 19, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants