Fix Scroll bug when chat is opened (the same issue was for menu)#21405
Merged
PunkPun merged 1 commit intoApr 30, 2024
Merged
Conversation
PunkPun
reviewed
Apr 24, 2024
RaushanSakhibzadin
force-pushed
the
scroll_bug_when_chat_is_opened
branch
from
6abc7b9 to
6b3b9e3
Compare
RoosterDragon
approved these changes
Apr 27, 2024
PunkPun
reviewed
Apr 30, 2024
PunkPun
left a comment
PunkPun
left a comment
Member
There was a problem hiding this comment.
LGTM, please squash the commits
RaushanSakhibzadin
force-pushed
the
scroll_bug_when_chat_is_opened
branch
2 times, most recently
from
43ab35e to
95f4f0d
Compare
PunkPun
approved these changes
Apr 30, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21344
Added conditions to halt scrolling when chat is opened
The same issue was for opening and closing the menu:
while holding any arrow key, open the menu, release the key, close the menu
the camera keeps moving
Best regards,
Raushan Sakhibzadin