Skip to content

Do not keep map packages loaded on Game start to reduce memory impact#21408

Merged
PunkPun merged 1 commit into
OpenRA:bleedfrom
cclecle:bleed
Apr 30, 2024
Merged

Do not keep map packages loaded on Game start to reduce memory impact#21408
PunkPun merged 1 commit into
OpenRA:bleedfrom
cclecle:bleed

Conversation

@cclecle

@cclecle cclecle commented Apr 24, 2024

Copy link
Copy Markdown

Address the following issue:
#21407

Comment thread OpenRA.Game/Map/MapCache.cs Outdated
Comment thread OpenRA.Game/Map/MapCache.cs Outdated
Comment thread OpenRA.Game/Map/MapCache.cs Outdated
Comment thread OpenRA.Game/Map/MapPreview.cs
Comment thread OpenRA.Game/Map/MapPreview.cs Outdated
Comment thread OpenRA.Game/Map/MapPreview.cs Outdated
Comment thread OpenRA.Game/Map/MapPreview.cs
Comment thread OpenRA.Game/Map/MapCache.cs Outdated
Comment thread OpenRA.Game/Map/MapCache.cs Outdated
Comment thread OpenRA.Game/Map/MapPreview.cs Outdated

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit e5a7b6e into OpenRA:bleed Apr 30, 2024
@PunkPun

PunkPun commented Apr 30, 2024

Copy link
Copy Markdown
Member

changelog

@PunkPun

PunkPun commented Apr 30, 2024

Copy link
Copy Markdown
Member

I think it would make sense to add package disposal on game end as to not be bloating the ram over time. Or on server start we could dispose of all but the selected map's package

@cclecle

cclecle commented Apr 30, 2024

Copy link
Copy Markdown
Author

thanks for the merge :)
I will have a look for the last comment.

@Mailaender Mailaender changed the title Do not keep map pakages loaded on Game start to reduce memory impact Do not keep map packages loaded on Game start to reduce memory impact May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants