Add WithSwitchableOverlay for Firestrom Generator#21413
Merged
PunkPun merged 2 commits intoOpenRA:bleedfrom May 19, 2024
Merged
Add WithSwitchableOverlay for Firestrom Generator#21413PunkPun merged 2 commits intoOpenRA:bleedfrom
PunkPun merged 2 commits intoOpenRA:bleedfrom
Conversation
Contributor
dnqbob
commented
May 1, 2024
dnqbob
commented
PunkPun
reviewed
May 7, 2024
Member
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
Overall LGTM, just a few naming nits
PunkPun
reviewed
May 7, 2024
dnqbob
force-pushed
the
switchable-overlay
branch
2 times, most recently
from
11765e1 to
36444da
Compare
PunkPun
reviewed
May 8, 2024
| else if (!string.IsNullOrEmpty(Info.DisabledSequence)) | ||
| overlay.PlayRepeating(RenderSprites.NormalizeSequence(overlay, self.GetDamageState(), Info.DisabledSequence)); | ||
| else if (!string.IsNullOrEmpty(Info.SwitchingSequence)) | ||
| overlay.PlayRepeating(RenderSprites.NormalizeSequence(overlay, self.GetDamageState(), Info.SwitchingSequence)); |
Member
There was a problem hiding this comment.
I'm just wondering. Does this pattern exist anywhere else? It feels a bit wrong for it to not be handling conditions. Perhaps it should be handled in INotifyCreated?
Contributor
Author
There was a problem hiding this comment.
Nah, it just because if there is no sequence being played, AnimationWithOffset will crash:
var anim = new AnimationWithOffset(overlay, ...);
The lines here try to find out a valid sequence, or any valid sequence to fill the blank since you must allow a null value for all sequences.
Contributor
Author
There was a problem hiding this comment.
That is the same even you move it to "INotifyCreated", and it is not related to conditions.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.