Skip to content

Spice bloom refactor - #21431

Merged
PunkPun merged 2 commits into
OpenRA:bleedfrom
Porenutak:spice-bloom-refactor
Jun 28, 2024
Merged

Spice bloom refactor#21431
PunkPun merged 2 commits into
OpenRA:bleedfrom
Porenutak:spice-bloom-refactor

Conversation

@Porenutak

Copy link
Copy Markdown
Contributor

What this refactor do:

  • int[] Pieces now behave as Min and Max instead of random interval. This is need to for competetive games where spice grow must be more in control. Min is used when spicebloom spawns and maximum when fully growed. All between as Min + GrowPercentage x (Max - Min)
  • Spawn one piece per tick similar OG.

Comment thread OpenRA.Mods.D2k/Traits/SpiceBloom.cs Outdated
Comment thread OpenRA.Mods.D2k/Traits/SpiceBloom.cs Outdated
Comment thread OpenRA.Mods.D2k/Traits/SpiceBloom.cs Outdated
Comment thread OpenRA.Mods.D2k/Traits/SpiceBloom.cs Outdated
@Porenutak
Porenutak force-pushed the spice-bloom-refactor branch from e8f358f to 0ffc2c1 Compare May 29, 2024 14:06
@Porenutak

Copy link
Copy Markdown
Contributor Author

Done, renamed Pieces to Bursts and Delay to BurstInterval

Comment thread OpenRA.Mods.D2k/Traits/SpiceBloom.cs Outdated
Comment thread OpenRA.Mods.D2k/Traits/SpiceBloom.cs Outdated
Comment thread OpenRA.Mods.D2k/Traits/SpiceBloom.cs Outdated
Comment thread OpenRA.Mods.D2k/Traits/SpiceBloom.cs Outdated
@Porenutak
Porenutak force-pushed the spice-bloom-refactor branch from 0ffc2c1 to 2a0269b Compare June 4, 2024 12:02
Comment thread OpenRA.Mods.D2k/Traits/SpiceBloom.cs
Comment thread OpenRA.Mods.D2k/Traits/SpiceBloom.cs Outdated
Porenutak and others added 2 commits June 18, 2024 09:09
- pieces represent Min and Max instead of random interval
- More control where spice spread
- fix AoE in  SpiceExplosion weapon
- delay interval between each pieces

Co-Authored-By: Gustas <37534529+PunkPun@users.noreply.github.com>
@Porenutak
Porenutak force-pushed the spice-bloom-refactor branch from f376864 to 8d1272b Compare June 18, 2024 07:09

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun
PunkPun merged commit 9066ff0 into OpenRA:bleed Jun 28, 2024
@PunkPun

PunkPun commented Jun 28, 2024

Copy link
Copy Markdown
Member

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants