Skip to content

Make InstantlyRepairs check types for the order issued - #21445

Merged
PunkPun merged 1 commit into
OpenRA:bleedfrom
cameo-mod:instantrepair
Jun 29, 2024
Merged

Make InstantlyRepairs check types for the order issued#21445
PunkPun merged 1 commit into
OpenRA:bleedfrom
cameo-mod:instantrepair

Conversation

@tjk-ws

@tjk-ws tjk-ws commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

Multiple InstantlyRepairs traits on an actor did not check the type used to actually give the order, so EnterBehaviour was defined only by the last trait defined on the actor even if another one was the type that actually applied. Test case with RA (consume for repairing base buildings vs exit for repairing tech buildings) included

@tjk-ws tjk-ws changed the title Make InstantlyRepairs properly support multiple types Make InstantlyRepairs check types for the order issued Jun 13, 2024
@PunkPun

PunkPun commented Jun 17, 2024

Copy link
Copy Markdown
Member

related #20359

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun
PunkPun merged commit fe35c42 into OpenRA:bleed Jun 29, 2024
@PunkPun

PunkPun commented Jun 29, 2024

Copy link
Copy Markdown
Member

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants