Skip to content

Fix aircraft that don't rearm stalling over invalid targets#21451

Merged
PunkPun merged 1 commit into
OpenRA:bleedfrom
cameo-mod:flyattack
Jun 17, 2024
Merged

Fix aircraft that don't rearm stalling over invalid targets#21451
PunkPun merged 1 commit into
OpenRA:bleedfrom
cameo-mod:flyattack

Conversation

@tjk-ws

@tjk-ws tjk-ws commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

The check for if an aircraft's weapons were invalid was only triggered if it was rearmable, so mods where it wasn't had the issue of stalling over targets when they became untargetable from conditions. The check for resupply is moved within the if-block, if not present the aircraft will just complete the flyattack activity.

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit 6a7159e into OpenRA:bleed Jun 17, 2024
@PunkPun

PunkPun commented Jun 17, 2024

Copy link
Copy Markdown
Member

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants