Download failure error.#21460
Merged
Merged
Conversation
RoosterDragon
approved these changes
Jun 29, 2024
PunkPun
reviewed
Jun 29, 2024
PunkPun
left a comment
PunkPun
left a comment
Member
There was a problem hiding this comment.
Is there an easy way to test this?
Member
|
Invert the condition to |
Contributor
|
Wouldn't it be practical then to also show the status code and message and even log the URL? |
Member
|
|
Member
|
However you are combining a localized string with a non-localized one: Would be nice if you could complete it. |
PunkPun
force-pushed
the
pr/download-failure-error
branch
from
4b0a546 to
20131fe
Compare
Member
|
that's scope creep, it's an issue that's already present and not introduced by this PR |
PunkPun
approved these changes
Oct 12, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when downloading mod content, if a download fails (e.g. due to 404), there's no error message or indication that anything failed, and it just returns to the downloads list. This adds an error message so it's clear something went wrong and allows retrying.