Make MiniYaml inherits and removal more flexible#21462
Merged
Merged
Conversation
Member
|
Related: #21444. |
RoosterDragon
force-pushed
the
fix-yaml-removal
branch
from
ed44e41 to
5b56843
Compare
RoosterDragon
changed the title
Member
Author
|
I've realised that as well as making removals more flexible, this also tackles an open request r.e. making Inherits more flexible. Have pushed an extra test case to cover that and updated the description. |
- Previously the Inherits syntax was only resolved when used for top-level nodes. Now it is also resolved for nested nodes as well. - Previously the MiniYAML Merge feature supported the ability to remove nodes, but this only worked within the context of inherited nodes. Now, we allow node removal to work outside of the inheritance context.
Follow-up from 34ff23d, the previous `-Remap:` line was not working and has since been removed. Without the remap being unapplied, there are rendering artefacts introduced as a result. Fix this by explicitly setting the remap to something else instead.
RoosterDragon
force-pushed
the
fix-yaml-removal
branch
from
5b56843 to
8e819f7
Compare
PunkPun
approved these changes
Jul 18, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Remapsyntax is now considered invalid (before it was valid, but was a no-op and not working as intended)Fixes #19580 Fixes #16278 Fixes #21444