Fixed a crash on empty mission options#21465
Merged
PunkPun merged 1 commit intoJul 5, 2024
Merged
Conversation
Mailaender
force-pushed
the
infiltration-mission-browser-crash
branch
from
a9ce561 to
508b48e
Compare
PunkPun
reviewed
Jul 3, 2024
Member
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
I think this is more an error on the map side. Maybe a better fix would be to improve linting?
Member
Author
|
I just imitate behavior from lobby logic, so I am very confident that I am on the right track. |
RoosterDragon
approved these changes
Jul 4, 2024
Member
RoosterDragon
left a comment
RoosterDragon
left a comment
There was a problem hiding this comment.
I think having this match the lobby logic when there are no option values makes sense.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21464.