Conversation
JovialFeline
force-pushed
the
fix-tanyas-tale-speakers
branch
from
8f494f6 to
ef49ffb
Compare
JovialFeline
changed the title
| if TanyaType == "e7.noautotarget" then | ||
| Trigger.AfterDelay(DateTime.Seconds(1), function() | ||
| Media.DisplayMessage(UserInterface.Translate("tanya-rules-of-engagement"), "Tanya") | ||
| Media.DisplayMessage(UserInterface.Translate("tanya-rules-of-engagement"), UserInterface.Translate("tanya")) |
There was a problem hiding this comment.
what do you thing, would it be better to reuse actor names? actor-e7.name
There was a problem hiding this comment.
should at least add comments of the new uses of the translations keys in en.ftl
There was a problem hiding this comment.
what do you thing, would it be better to reuse actor names?
actor-e7.name
I'm practically just a mapper but I wouldn't mind. I referenced the same key through tanya.TooltipName in Negotiations, and the guide also used their tooltip name.
There was a problem hiding this comment.
People who might translate this would have trouble with a cryptic key like actor-e7.name as it requires studying the game rules to understand.
JovialFeline
force-pushed
the
fix-tanyas-tale-speakers
branch
from
ef49ffb to
db143b9
Compare
JovialFeline
force-pushed
the
fix-tanyas-tale-speakers
branch
from
db143b9 to
e4ea4c9
Compare
|
|
||
| if #units > 0 then | ||
| Media.DisplayMessage("Harkonnen units approaching!", "Fremen Leader") | ||
| Media.DisplayMessage(UserInterface.Translate("harkonnen-units-approaching"), UserInterface.Translate("fremen-leader")) |
There was a problem hiding this comment.
it doesn't looks like SendAttack is even called anywhere
There was a problem hiding this comment.
ah, it's supposed to be called by ProduceUnits(), but I can't get this notification ingame
3 participants
There are messages in Tanya's Tale where the text is fine but the translation for a speaker goes unused.
I didn't find a mismatch like this in other scripts.
A similar search turned up untranslated messages in RA's Situation Critical and D2k's
atreides-04, so I've tossed in a fix for those.