Expose factions to localisation#21484
Merged
Merged
Conversation
Mailaender
force-pushed
the
l10n-factions
branch
from
2e1869d to
34df385
Compare
Mailaender
force-pushed
the
l10n-factions
branch
from
34df385 to
47299aa
Compare
Member
Author
|
Fixed the |
PunkPun
reviewed
Jul 17, 2024
Mailaender
force-pushed
the
l10n-factions
branch
from
47299aa to
6bc7715
Compare
Member
Author
|
That dropdown is unavailable to me. I tried to localize it nonetheless. |
Member
|
you need to select player type apparently for it to become available |
Mailaender
force-pushed
the
l10n-factions
branch
from
6bc7715 to
8074420
Compare
PunkPun
approved these changes
Jul 18, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plus a regression from #21221 fixed that appeared during string extraction and testing.