Skip to content

Expose bot names to localization - #21489

Merged
PunkPun merged 3 commits into
OpenRA:bleedfrom
Mailaender:l10n-bots
Aug 5, 2024
Merged

Expose bot names to localization#21489
PunkPun merged 3 commits into
OpenRA:bleedfrom
Mailaender:l10n-bots

Conversation

@Mailaender

@Mailaender Mailaender commented Jul 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

as not all of them are proper names.

@Mailaender Mailaender mentioned this pull request Jul 18, 2024
Open
16 tasks
@Mailaender
Mailaender force-pushed the l10n-bots branch 2 times, most recently from 291c56f to 10355d5 Compare July 18, 2024 20:58
PunkPun
PunkPun reviewed Jul 19, 2024
View reviewed changes
Comment thread OpenRA.Mods.Common/Traits/Player/ModularBot.cs Outdated
RoosterDragon
RoosterDragon reviewed Jul 19, 2024
View reviewed changes
Comment thread OpenRA.Mods.Common/Traits/Player/ModularBot.cs
pchote
pchote reviewed Jul 19, 2024
View reviewed changes
Comment thread mods/cnc/languages/rules/en.ftl Outdated
@Mailaender

Mailaender commented Jul 26, 2024

Copy link
Copy Markdown
Member Author

grafik

RoosterDragon
RoosterDragon reviewed Jul 26, 2024
View reviewed changes
Comment thread OpenRA.Mods.Common/Widgets/Logic/Lobby/LobbyUtils.cs
RoosterDragon
RoosterDragon reviewed Jul 26, 2024
View reviewed changes
Comment thread mods/cnc/languages/chrome/en.ftl Outdated
@Mailaender
Mailaender force-pushed the l10n-bots branch 2 times, most recently from a2135d9 to 5cf77bd Compare July 26, 2024 18:30
PunkPun
PunkPun reviewed Jul 26, 2024
View reviewed changes

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we are still translating on bot owner side. So the names will be localised incorrectly for other players and replays

Screenshot 2024-07-26 at 21 48 00

this font also seems humongous

PunkPun
PunkPun reviewed Jul 26, 2024
View reviewed changes

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-26 at 21 52 08

@Mailaender
Mailaender force-pushed the l10n-bots branch 2 times, most recently from 0bef69b to c5b12d3 Compare July 26, 2024 19:45
@Mailaender

Mailaender commented Jul 26, 2024

Copy link
Copy Markdown
Member Author

You are right. I moved the translation into UI code now.

PunkPun
PunkPun reviewed Jul 26, 2024
View reviewed changes

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this hasn't fixed it

Screenshot 2024-07-26 at 23 20 02

Comment thread OpenRA.Game/Player.cs Outdated
@Mailaender

Mailaender commented Jul 27, 2024

Copy link
Copy Markdown
Member Author

Updated to keep the replays also client side translated.
grafik

Also added localization for player name suffixes.

@Mailaender
Mailaender force-pushed the l10n-bots branch 2 times, most recently from e724d25 to 467e544 Compare July 27, 2024 14:22
PunkPun
PunkPun reviewed Jul 28, 2024
View reviewed changes

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the translated name still appears in replays at the very bottom. I'm also afraid of it appearing in sync checks

@PunkPun

PunkPun commented Jul 28, 2024

Copy link
Copy Markdown
Member

maybe also try watching the TranslationProvider during a multiplayer match to check wether it receives any requests to translate already translated AI names

@Dzierzan Dzierzan mentioned this pull request Jul 31, 2024
Merged
PunkPun
PunkPun reviewed Aug 3, 2024
View reviewed changes

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

Comment thread OpenRA.Game/GameInformation.cs Outdated
Comment thread OpenRA.Game/Player.cs
Comment thread mods/common/languages/en.ftl Outdated
@Mailaender
Mailaender force-pushed the l10n-bots branch 2 times, most recently from 5303920 to f0f4876 Compare August 3, 2024 13:24
@Mailaender

Mailaender commented Aug 3, 2024

Copy link
Copy Markdown
Member Author

Also contains new artwork by @Dzierzan
grafik

@pchote

pchote commented Aug 3, 2024

Copy link
Copy Markdown
Member

Were the artwork changes made to the artsrc svg, or directly in the exported pngs?

PunkPun
PunkPun reviewed Aug 3, 2024
View reviewed changes
Comment thread OpenRA.Mods.Common/Widgets/WidgetUtils.cs Outdated
@Mailaender

Mailaender commented Aug 3, 2024

Copy link
Copy Markdown
Member Author

Were the artwork changes made to the artsrc svg, or directly in the exported pngs?

OpenRA/ArtSrc#23

@PunkPun

PunkPun commented Aug 3, 2024

Copy link
Copy Markdown
Member

OpenRA/ArtSrc#23 was updated

@PunkPun
PunkPun merged commit c24913e into OpenRA:bleed Aug 5, 2024
@PunkPun

PunkPun commented Aug 5, 2024

Copy link
Copy Markdown
Member

chnagelog

@Mailaender
Mailaender deleted the l10n-bots branch August 5, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pchote pchote pchote left review comments
@PunkPun PunkPun PunkPun approved these changes
+1 more reviewer
@RoosterDragon RoosterDragon RoosterDragon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Needs +2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mailaender @PunkPun @pchote @RoosterDragon