Fix movement on ramps when moving to a subcell#21491
Merged
Merged
Conversation
towelcoded
force-pushed
the
FixRampMoveWithSubcell
branch
from
1df1eed to
cb1a4f1
Compare
Member
RoosterDragon
left a comment
RoosterDragon
left a comment
There was a problem hiding this comment.
Can confirm this works. Add the following to the TS rules to allow infantry to be crushed by friendlies.
OpenRA/mods/ts/rules/defaults.yaml
Line 551 in 7b01204
Crushable:
WarnProbability: 0
CrushedByFriendlies: TrueOn bleed, they will crush on the flat, but crushing on slopes fails. With this PR, the crushing on slopes is resolved.
Member
|
This raises some extra questions for me, such as:
No need to block the PR on answering those - probably something for a separate issue - just mulling really. |
RoosterDragon
approved these changes
Jul 21, 2024
Member
RoosterDragon
left a comment
RoosterDragon
left a comment
There was a problem hiding this comment.
Please squash the fixup commit.
Fix movement on ramps when moving to subcell
towelcoded
force-pushed
the
FixRampMoveWithSubcell
branch
from
5399840 to
35127b9
Compare
Contributor
Author
done. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When infantry moves on ramps their position's Z value got reset to the cell center's height despite them moving to a subcell that is off-center. Also when ending their movement there was some adjusting to the X and Y position that left the Z value unchanged. As a result infantry on a ramp would always end up with a non-zero distance above ground.
This fix keeps ground units at the correct height for the ramp they are on even if they don't end their movement at the cell's center.
Fixes #21375