Skip to content

Fix map update with incompatible ZIP extra data - #21492

Merged
PunkPun merged 1 commit into
OpenRA:bleedfrom
Mailaender:zip-extra-data
Aug 10, 2024
Merged

Fix map update with incompatible ZIP extra data#21492
PunkPun merged 1 commit into
OpenRA:bleedfrom
Mailaender:zip-extra-data

Conversation

@Mailaender

Copy link
Copy Markdown
Member

Closes #21323

Comment thread OpenRA.Game/FileSystem/ZipFile.cs Outdated

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this works. I tried using the default macOS zipper and it still can't read it.

I get System.IO.FileNotFoundException: Required file map.yaml not present in this map

af_patching.zip

version with sanitisation run. Same crash

af_patching.zip

@pchote

pchote commented Jul 29, 2024

Copy link
Copy Markdown
Member

That zip file contains a directory af_patching that contains map.yaml etc, which is invalid with or without this fix!

Comment thread OpenRA.Game/FileSystem/ZipFile.cs
@PunkPun
PunkPun merged commit 2d0b5f5 into OpenRA:bleed Aug 10, 2024

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mailaender
Mailaender deleted the zip-extra-data branch August 10, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support packing maps to .oramap using third-party software

3 participants