Pass order name to OrderEffects

[towelcoded]

Pass the order name to OrderEffects (until now, only the target was passed) to allow mods to scope their custom order effects to specific orders.

Required by OpenE2140 for the attack flash animation.

[pchote]

IMO this is making the upstream trait needlessly complicated, and it would be better for E2140 to simply implement its own trait that implements INotifyOrderIssued (with us taking the interface tweak from the other PR).

[towelcoded]

IMO this is making the upstream trait needlessly complicated, and it would be better for E2140 to simply implement its own trait that implements INotifyOrderIssued (with us taking the interface tweak from the other PR).

So do we keep the scoping here, or should I move everything except passing the order name to OrderEffects to our custom trait?

[pchote]

My preference would be moving everything except passing the order name to OrderEffects to your custom trait

[PunkPun]

I think this PR made sense (before the last push). A filter for orders is a good addition, but instead of a whitelist I think having both a whitelist and blacklist would be better. Then you could easily duplicate the traits for various effects

[pchote]

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/9d854daf7919fa9695086c04a7e892910ad6e2d4