Improve generality of SpriteCache AdjustFrame.#21519
Merged
Merged
Conversation
pchote
force-pushed
the
sprite-cache-tweaks
branch
from
August 3, 2024 20:44
de24c86 to
70a1a44
Compare
Member
Author
|
Updated |
pchote
force-pushed
the
sprite-cache-tweaks
branch
from
August 3, 2024 20:56
70a1a44 to
b6c42ef
Compare
RoosterDragon
approved these changes
Aug 4, 2024
Member
|
needs a rabase |
This allows users (currently TDHD) to load ISpriteFrames directly, without them being stored in the cache.
pchote
force-pushed
the
sprite-cache-tweaks
branch
from
August 4, 2024 22:48
b6c42ef to
6db1a73
Compare
Member
Author
|
I'd prefer to cncbase, but done 😉 |
PunkPun
reviewed
Aug 5, 2024
| } | ||
|
|
||
| static ISpriteFrame[] GetFrames(IReadOnlyFileSystem fileSystem, string filename, ISpriteLoader[] loaders, out TypeDictionary metadata) | ||
| static ISpriteFrame[] GetFrames(IReadOnlyFileSystem fileSystem, string filename, ISpriteLoader[] loaders) |
Member
There was a problem hiding this comment.
while this probably isn't the right place to get metadata, it seems to be the only place. I recall @IceReaper having issues about metadata being disposed
Contributor
There was a problem hiding this comment.
Yeah, kknd has per frame metadata like 2d bone positions. Thats required to make the actors look like they should look when animating them
PunkPun
approved these changes
Aug 5, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some tweaks to #21369 to restore support for TDHD, and makes some small cleanups to D2kSpriteSequence.