Make map editor brush rendering self-contained - #21529
Merged
Merged
Conversation
pchote
reviewed
Aug 7, 2024
PunkPun
force-pushed
the
brushes
branch
2 times, most recently
from
August 10, 2024 13:54
efb566b to
464fc1a
Compare
RoosterDragon
left a comment
RoosterDragon
left a comment
Member
There was a problem hiding this comment.
Solid refactoring and I gave all the editor tabs a go to check they were still operating.
PunkPun
force-pushed
the
brushes
branch
2 times, most recently
from
September 14, 2024 18:45
527abb4 to
7c95dc7
Compare
RoosterDragon
approved these changes
Sep 14, 2024
pchote
reviewed
Sep 15, 2024
Member
|
LGTM otherwise |
pchote
reviewed
Sep 15, 2024
Member
|
Sorry to say that something is off with the TD editor UI: the selection panel is more opaque than the others, which suggests that the background is being drawn twice. The height of the panel also jumps around when changing tabs, partially covering the debug text. |
pchote
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20920 and contains other polish that I didn't bikeshed earlier
This makes adding new brushes much easier as the code is no longer scattered all over the place.
The PR is based on the change to the
IEditorBrushinterface.