English language copy editing + fact checking - #21547
Merged
Merged
Conversation
PunkPun
force-pushed
the
Language-Errors
branch
2 times, most recently
from
August 19, 2024 17:37
f414ce6 to
e4ad94d
Compare
Mailaender
reviewed
Aug 19, 2024
Mailaender
reviewed
Aug 19, 2024
Mailaender
reviewed
Aug 19, 2024
Mailaender
reviewed
Aug 19, 2024
Mailaender
reviewed
Aug 19, 2024
Mailaender
reviewed
Aug 19, 2024
Mailaender
reviewed
Aug 19, 2024
Mailaender
reviewed
Aug 19, 2024
PunkPun
force-pushed
the
Language-Errors
branch
3 times, most recently
from
August 20, 2024 09:01
3504e1c to
ef1016d
Compare
Mailaender
reviewed
Aug 20, 2024
PunkPun
force-pushed
the
Language-Errors
branch
from
August 20, 2024 16:16
ef1016d to
bf4b4a3
Compare
PunkPun
force-pushed
the
Language-Errors
branch
3 times, most recently
from
August 25, 2024 13:47
a43e2cd to
1de3945
Compare
Contributor
Author
|
There’s a list of potential errors on the Discord thread that need yes/no answers. Once the list is done, the PR will be close to being finished. |
PunkPun
force-pushed
the
Language-Errors
branch
from
August 26, 2024 09:59
1de3945 to
9f95df4
Compare
PunkPun
force-pushed
the
Language-Errors
branch
2 times, most recently
from
August 31, 2024 06:35
070f196 to
b07065b
Compare
RoosterDragon
suggested changes
Sep 13, 2024
PunkPun
force-pushed
the
Language-Errors
branch
from
September 29, 2024 09:29
b07065b to
ca977bb
Compare
PunkPun
force-pushed
the
Language-Errors
branch
6 times, most recently
from
October 18, 2024 17:29
8f75db9 to
1f2a966
Compare
PunkPun
force-pushed
the
Language-Errors
branch
2 times, most recently
from
October 20, 2024 14:25
7276e3e to
2397fb3
Compare
PunkPun
reviewed
Oct 20, 2024
PunkPun
left a comment
Member
There was a problem hiding this comment.
punctuation is very inconsistent and needs to be reviewed.
- notifications appear in chat, they should have punctuation.
- most tooltips should not have punctuation, 2 exceptions I can think of are unit and faction descriptions (they are much bigger).
- prompts should not have punctuation
some of the newline removals are a downgrade
Co-Authored-By: Gustas <37534529+punkpun@users.noreply.github.com>
PunkPun
force-pushed
the
Language-Errors
branch
from
October 23, 2024 09:57
e2bc69c to
7ae1289
Compare
PunkPun
reviewed
Oct 23, 2024
Co-Authored-By: Gustas <37534529+punkpun@users.noreply.github.com>
Co-Authored-By: Gustas <37534529+punkpun@users.noreply.github.com>
PunkPun
force-pushed
the
Language-Errors
branch
from
October 23, 2024 16:03
f7be964 to
c2dec86
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credit also goes to by @JovialFeline for answering my many questions and @PunkPun for GitHub help.
For discussions related to wording, grammar, structure and typos in FTL translation keys, values and corresponding files.
All changes will need to be tested in-game. Wrapping issues will inevitably occur when text becomes longer.
Guidelines