Skip to content

English language copy editing + fact checking - #21547

Merged
PunkPun merged 4 commits into
OpenRA:bleedfrom
test1232156:Language-Errors
Oct 23, 2024
Merged

English language copy editing + fact checking#21547
PunkPun merged 4 commits into
OpenRA:bleedfrom
test1232156:Language-Errors

Conversation

@test1232156

@test1232156 test1232156 commented Aug 18, 2024

Copy link
Copy Markdown
Contributor

Credit also goes to by @JovialFeline for answering my many questions and @PunkPun for GitHub help.

For discussions related to wording, grammar, structure and typos in FTL translation keys, values and corresponding files.

All changes will need to be tested in-game. Wrapping issues will inevitably occur when text becomes longer.

Guidelines

  • Provide the error and the suggested change in the review.
  • If any issues require further discussion, such as reverting a suggested change or uncertain cases, raise them in the Discord thread.
  • Avoid making multiple reviews for the same type of error (e.g., spacing); list them together if there are only a few, or note that there are multiple occurrences if many.
  • Encyclopedia changes go to the encyclopedia PRs
  • Exclude full stop error changes for now, until a style guide for them is written. Same goes for capitalisation.

@PunkPun PunkPun added this to the Next Release milestone Aug 18, 2024
@PunkPun
PunkPun force-pushed the Language-Errors branch 2 times, most recently from f414ce6 to e4ad94d Compare August 19, 2024 17:37
Comment thread mods/cnc/languages/rules/en.ftl Outdated
Comment thread mods/ra/languages/rules/en.ftl Outdated
Comment thread mods/cnc/languages/chrome/en.ftl Outdated
Comment thread mods/cnc/languages/chrome/en.ftl Outdated
Comment thread mods/ts/languages/rules/en.ftl Outdated
Comment thread mods/ts/languages/rules/en.ftl Outdated
Comment thread mods/ts/languages/rules/en.ftl Outdated
Comment thread mods/ts/languages/rules/en.ftl Outdated
Comment thread mods/ts/languages/rules/en.ftl Outdated
Comment thread mods/cnc/languages/rules/en.ftl Outdated
@PunkPun
PunkPun force-pushed the Language-Errors branch 3 times, most recently from 3504e1c to ef1016d Compare August 20, 2024 09:01
Comment thread mods/common/languages/chrome/en.ftl Outdated
@Mailaender Mailaender changed the title Language errors English language copy editing Aug 20, 2024
@test1232156 test1232156 changed the title English language copy editing English language copy editing + fact checking Aug 20, 2024
@PunkPun
PunkPun force-pushed the Language-Errors branch 3 times, most recently from a43e2cd to 1de3945 Compare August 25, 2024 13:47
@test1232156

Copy link
Copy Markdown
Contributor Author

There’s a list of potential errors on the Discord thread that need yes/no answers. Once the list is done, the PR will be close to being finished.

@PunkPun
PunkPun force-pushed the Language-Errors branch 2 times, most recently from 070f196 to b07065b Compare August 31, 2024 06:35
Comment thread mods/cnc/languages/chrome/en.ftl Outdated
Comment thread mods/cnc/languages/rules/en.ftl Outdated
Comment thread mods/cnc/languages/rules/en.ftl
Comment thread mods/cnc/languages/rules/en.ftl Outdated
Comment thread mods/cnc/languages/rules/en.ftl Outdated
Comment thread mods/ra/languages/rules/en.ftl Outdated
Comment thread mods/ts/languages/chrome/en.ftl Outdated
Comment thread mods/ts/languages/rules/en.ftl Outdated
Comment thread mods/ts/languages/rules/en.ftl Outdated
Comment thread mods/ts/languages/rules/en.ftl
@PunkPun PunkPun removed this from the Next Release milestone Sep 15, 2024
@PunkPun
PunkPun force-pushed the Language-Errors branch 6 times, most recently from 8f75db9 to 1f2a966 Compare October 18, 2024 17:29
@PunkPun
PunkPun force-pushed the Language-Errors branch 2 times, most recently from 7276e3e to 2397fb3 Compare October 20, 2024 14:25

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

punctuation is very inconsistent and needs to be reviewed.

  • notifications appear in chat, they should have punctuation.
  • most tooltips should not have punctuation, 2 exceptions I can think of are unit and faction descriptions (they are much bigger).
  • prompts should not have punctuation

some of the newline removals are a downgrade

Comment thread mods/cnc/languages/rules/en.ftl Outdated
Comment thread mods/cnc/languages/rules/en.ftl Outdated
Comment thread mods/cnc/languages/rules/en.ftl
Comment thread mods/cnc/languages/rules/en.ftl
Comment thread mods/cnc/languages/rules/en.ftl Outdated
Comment thread mods/ra/languages/rules/en.ftl Outdated
Comment thread mods/ra/languages/rules/en.ftl Outdated
Comment thread mods/ra/languages/rules/en.ftl Outdated
Comment thread mods/ra/languages/rules/en.ftl Outdated
Comment thread mods/ts/languages/rules/en.ftl Outdated
Co-Authored-By: Gustas <37534529+punkpun@users.noreply.github.com>
Comment thread mods/cnc/languages/rules/en.ftl Outdated
Comment thread mods/cnc/languages/rules/en.ftl Outdated
test1232156 and others added 3 commits October 23, 2024 19:03
Co-Authored-By: Gustas <37534529+punkpun@users.noreply.github.com>
Co-Authored-By: Gustas <37534529+punkpun@users.noreply.github.com>

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun
PunkPun merged commit b62c883 into OpenRA:bleed Oct 23, 2024
@PunkPun
PunkPun deleted the Language-Errors branch October 23, 2024 16:08
@PunkPun

PunkPun commented Oct 23, 2024

Copy link
Copy Markdown
Member

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants