Use a smaller sheet in CursorManager.#21557
Conversation
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
the RA one seems quite full
I recon it would make sense to add this sheet to the dump sheet command
bleed...PunkPun:OpenRA:Dump-cursors
Disposal seems to be all over the place
91fda1b to
e04615a
Compare
Exposed the size via
Seems like a reasonable thing to PR.
Not sure how it has a |
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
Not sure how it has a Dispose but didn't implement IDisposable - added in.
I'm not sure as well. But disposal isn't properly handled. Some things that should be disposed are never disposed within the class as well
Provide an explicit size of 512, smaller than the default 2048. The cursors for all mods still pack onto this single sheet, so we avoid wasting memory on larger sheets. Sorting the cursors also helps pack them onto the sheets more efficiently.
47a3862 to
c1f2ead
Compare
It looks okay to me. Can you show me what you'd add to the |
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
All base mods don't overflow into secondary sheets
3 participants
Provide an explicit size of 512, smaller than the default 2048. The cursors for all mods still pack onto this single sheet, so we avoid wasting memory on larger sheets.
Sorting the cursors also helps pack them onto the sheets more efficiently.