Missions rules.yaml wording/typo fixes#21570
Merged
PunkPun merged 2 commits intoOct 18, 2024
Merged
Conversation
pchote
reviewed
Aug 31, 2024
PunkPun
reviewed
Aug 31, 2024
Member
There was a problem hiding this comment.
For a follow up PR we may want to add context to lua translation keys. They need to be separated to
objective-
notification-
missiontext-
announcer-
announcers and mission text should not have punctuation, or at most mission text could have an exclamation mark. While objectives and notifications should have punctuation
pchote
reviewed
Aug 31, 2024
PunkPun
reviewed
Sep 4, 2024
PunkPun
force-pushed
the
Missions-rules.yaml-typo-fixes
branch
from
f096647 to
c43e06a
Compare
PunkPun
reviewed
Sep 14, 2024
PunkPun
reviewed
Sep 14, 2024
PunkPun
reviewed
Sep 14, 2024
PunkPun
force-pushed
the
Missions-rules.yaml-typo-fixes
branch
from
c43e06a to
0051b96
Compare
pchote
reviewed
Sep 16, 2024
PunkPun
force-pushed
the
Missions-rules.yaml-typo-fixes
branch
from
d9dd0bc to
0546067
Compare
PunkPun
force-pushed
the
Missions-rules.yaml-typo-fixes
branch
from
0546067 to
5d5fc98
Compare
PunkPun
force-pushed
the
Missions-rules.yaml-typo-fixes
branch
from
6f5fd93 to
6e467be
Compare
pchote
reviewed
Oct 17, 2024
pchote
reviewed
Oct 17, 2024
Co-Authored-By: Gustas <37534529+punkpun@users.noreply.github.com>
PunkPun
force-pushed
the
Missions-rules.yaml-typo-fixes
branch
from
598d3ca to
984a17a
Compare
Co-Authored-By: Gustas <37534529+punkpun@users.noreply.github.com>
PunkPun
force-pushed
the
Missions-rules.yaml-typo-fixes
branch
from
984a17a to
5ab8526
Compare
PunkPun
approved these changes
Oct 18, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wording improvements to mission briefings, a few typo fixes and a spelling standardised.