Fix OrderManager being deleted in map editor

[PunkPun]

Fixes 1 cause for #21290

The mission selector deletes OrderManager on exit, which doesn't make much sense. We can just remove it

[Mailaender]

It seems you are just moving it.

[PunkPun]

By moving it I'm removing it from IngameMenuLogic

[Mailaender]

Fix OrderManager being deleted in map editor

This is about MissionBrowserLogic so the commit message seems off.

[PunkPun]

But it is specifically fixing mission browser in the map editor

[Mailaender]

The mission browser can't be accessed through the map editor. I can't follow. Try to explain in more detail with a step by step on how to reproduce the original issue.

[JovialFeline]

The mission browser can't be accessed through the map editor. I can't follow. Try to explain in more detail with a step by step on how to reproduce the original issue.

This is at least one of the issues, I take it.

2024-09-10_17-22-10.mp4

• Load a mission in the editor.
• Click Play Map.
• Click Back.
• Try to exit the editor.

[Mailaender]

Thanks. Now I get it. I didn't know that we launch the mission browser when pressing play map because for skirmish maps it is the lobby. It still freezes for skirmish maps. I assume the fix is the same problem, so would be nice to have that fixed as well.

[PunkPun]

It is the same problem, but both the reason and the fix to it is much much more complex. To the point where I want to just hack exiting behaviour

[Mailaender]

Changelog