Skip to content

Change ActorIndex to work in terms of TraitInfo, instead of Trait. - #21579

Merged
PunkPun merged 1 commit into
OpenRA:bleedfrom
RoosterDragon:actor-index-info
Sep 18, 2024
Merged

Change ActorIndex to work in terms of TraitInfo, instead of Trait.#21579
PunkPun merged 1 commit into
OpenRA:bleedfrom
RoosterDragon:actor-index-info

Conversation

@RoosterDragon

Copy link
Copy Markdown
Member

This allows actor.Info.HasTraitInfo to be used when checking if an actor needs to be added to the index, which is a cheaper call than actor.TraitsImplementing.

Closes #21485

This allows actor.Info.HasTraitInfo to be used when checking if an actor needs to be added to the index, which is a cheaper call than actor.TraitsImplementing.

@anvilvapre anvilvapre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested.

Comment thread OpenRA.Mods.Common/ActorIndex.cs

@pchote pchote left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread OpenRA.Mods.Common/ActorIndex.cs
@PunkPun
PunkPun merged commit ab50182 into OpenRA:bleed Sep 18, 2024
@PunkPun

PunkPun commented Sep 18, 2024

Copy link
Copy Markdown
Member

changelog

@RoosterDragon
RoosterDragon deleted the actor-index-info branch September 18, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ActorIndex, use ActorInfo.constructOrderCache

4 participants