Fixed wrong support folder when using .NET 8 on Unix#21583
Merged
Conversation
Member
|
So to make sure I'm reading the notes correctly:
Therefore making this changes doesn't break net6, and fixes us in prep for net8.
|
Contributor
|
ms will always stay ms. |
Member
|
According to https://learn.microsoft.com/en-gb/dotnet/core/compatibility/core-libraries/8.0/getfolderpath-unix#macos, yes, macOS will also need to be changed. |
Mailaender
force-pushed
the
net8-personal-folder
branch
from
September 16, 2024 16:33
59ad8f5 to
ffea403
Compare
PunkPun
approved these changes
Sep 16, 2024
Member
Member
|
The default case also appears to be a Linux flavour as well, I think that should've been updated too. |
Member
Author
|
No, that would be covered by the platform Linux case. Did I miss BSD? |
Member
|
I don't know what platforms would trigger the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It saves into
~/Documents/.config/openra/instead of~/.config/openra/on Linux. https://learn.microsoft.com/dotnet/core/compatibility/core-libraries/8.0/getfolderpath-unix Discovered during #21577. Also effects https://launchpad.net/~xtradeb/+archive/ubuntu/play/+build/28130160 which is already on .NET 8.