Expose hotkeys to localisation.#21588
Conversation
| ret = (Platform.CurrentPlatform == PlatformType.OSX ? "Cmd + " : "Meta + ") + ret; | ||
| ret = $"{ModifiersExts.DisplayString(Modifiers.Meta)} + {ret}"; | ||
|
|
||
| return ret; |
There was a problem hiding this comment.
This should really be called only once and cached . Key is a readonly value
There was a problem hiding this comment.
Not sure that's a worthwhile trade. Caching it would be an expense for callers the create a Hotkey but never call DisplayString - and there's not many callers of DisplayString.
There was a problem hiding this comment.
We don't need to keep keys in memory at all, so I dunno if it's a tradeoff
There was a problem hiding this comment.
I don't understand your comment.
| return k.ToString(); | ||
|
|
||
| return ret; | ||
| return TranslationProvider.GetString(translationKey); |
There was a problem hiding this comment.
This should also be cached, this is only used in Hotkey so might be better to move it there for LoB
RoosterDragon
force-pushed
the
hotkeys-ftl
branch
4 times, most recently
from
27f045d to
a271d3b
Compare
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
looks like we are repeating lint errors
could these be deduplicated?
Allows the Settings > Hotkeys screen to be localised, including hotkey decriptions, groups and contexts. The hotkey names are exposed to localisation via KeycodeExts. Hotkey modifiers are similarly exposed via ModifersExts. The Settings > Input screen has a Zoom Modifier dropdown, which shows the localised modifier name. The --check-yaml utility command is taught to recognise all hotkey translation, so it can validate their usage.
RoosterDragon
force-pushed
the
hotkeys-ftl
branch
from
a271d3b to
2808753
Compare
|
They're not duplicates - the message just isn't providing all the detail. I have pushed a commit which provides more detail in the message: |
4 participants
Allows the Settings > Hotkeys screen to be localised, including hotkey decriptions, groups and contexts.
The hotkey names are exposed to localisation via KeycodeExts. Hotkey modifiers are similarly exposed via ModifersExts.
The Settings > Input screen has a Zoom Modifier dropdown, which shows the localised modifier name.
The --check-yaml utility command is taught to recognise all hotkey translation, so it can validate their usage.