Replace hardcoded mod.yaml Packages list with a mod-defined filesystem loader#21598
Merged
PunkPun merged 5 commits intoOpenRA:bleedfrom Oct 2, 2024
Merged
Replace hardcoded mod.yaml Packages list with a mod-defined filesystem loader#21598PunkPun merged 5 commits intoOpenRA:bleedfrom
PunkPun merged 5 commits intoOpenRA:bleedfrom
Conversation
This allows mods with custom content requirements to use the default load screen implementations.
Contributor
|
This looks like a big change, shouldn't there be an update rule for it? |
Member
Author
|
Most of the yaml changes are just indentation. Update rules can't change mod.yaml because the utility needs a working mod.yaml to run. |
PunkPun
approved these changes
Sep 29, 2024
Member
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
Overall LGTM, I didn't find any regressions on getting files from the cnc remastered steam edition, nor quick install
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows mod code to customize the way that the filesystem is mounted. This makes it possible for mods to find and mount content dynamically without relying on load screen hacks and duplicated utility commands.
Corresponding TDHD commit showing the benefits of this PR: OpenRA/TiberianDawnHD@9645e00