Remove key handling from ContainerWidget - #21600
Merged
Merged
Conversation
dragunoff
force-pushed
the
feature/container-no-key-press
branch
from
October 2, 2024 09:28
c579d3b to
4e97a1d
Compare
Contributor
Author
|
Update: rebased |
It has no business handling key input. This was used only for opening the ingame chat and replacing it with a `LogicKeyListener` was trivial.
dragunoff
force-pushed
the
feature/container-no-key-press
branch
from
October 4, 2024 08:31
4e97a1d to
e2b7a87
Compare
Contributor
Author
|
Update: rebased on bleed so this can move forward independently of #21599 |
PunkPun
approved these changes
Oct 4, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has no business handling key input. This was used only for opening the ingame chat and replacing it with a
LogicKeyListenerwas trivial.Depends on #21599