Extract version label chrome logic to a dedicated class#21603
Merged
PunkPun merged 1 commit intoOct 3, 2024
Conversation
pchote
reviewed
Oct 3, 2024
pchote
left a comment
pchote
left a comment
Member
There was a problem hiding this comment.
Good idea, this also solves some duplication i had in TDHD 🎉
dragunoff
force-pushed
the
feature/version-label-chrome-logic
branch
from
1114f3d to
1ea392d
Compare
Contributor
Author
|
Update: added file header. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces some duplication and encapsulates this simple logic.