Extract player profile loading chrome logic to a dedicated class#21604
Merged
PunkPun merged 2 commits intoOpenRA:bleedfrom Oct 15, 2024
Merged
Extract player profile loading chrome logic to a dedicated class#21604PunkPun merged 2 commits intoOpenRA:bleedfrom
PunkPun merged 2 commits intoOpenRA:bleedfrom
Conversation
dragunoff
force-pushed
the
feature/player-profile-chrome-logic
branch
from
e4c38a6 to
99001ae
Compare
RoosterDragon
approved these changes
Oct 5, 2024
dragunoff
force-pushed
the
feature/player-profile-chrome-logic
branch
from
99001ae to
f73043d
Compare
Contributor
Author
|
Update: rebased and extracted |
PunkPun
approved these changes
Oct 15, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce a bit the clutter in
MainMenuLogic.csand inPlayerProfileLogic.cs