Remove PARENT_TOP and PARENT_LEFT from integer expressions for widgets#21605
Merged
PunkPun merged 1 commit intoOpenRA:bleedfrom Oct 3, 2024
Merged
Conversation
dragunoff
changed the title
PARENT_TOP and PARENT_LEFT from integer expressions for widgets
dragunoff
changed the title
PARENT_TOP and PARENT_LEFT from integer expressions for widgetsPARENT_TOP and PARENT_LEFT should be 0 so they are not very useful substitutions. They are replaced with 0 or removed if that was the whole value for a field.
dragunoff
force-pushed
the
feature/remove-parent-top-parent-left
branch
from
6bcbae7 to
2f15678
Compare
Contributor
Author
|
Update: reference the update rule in UpdatePath.cs |
PunkPun
approved these changes
Oct 3, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PARENT_TOPandPARENT_LEFTshould be0so they are not very useful substitutions. They are replaced with0or removed if that was the whole value for a field.