Skip to content

Rework mod content installation.#21623

Merged
PunkPun merged 2 commits into
OpenRA:bleedfrom
pchote:installer
Oct 20, 2024
Merged

Rework mod content installation.#21623
PunkPun merged 2 commits into
OpenRA:bleedfrom
pchote:installer

Conversation

@pchote

@pchote pchote commented Oct 15, 2024

Copy link
Copy Markdown
Member

This PR removes the magic cross-mod inheritance that was originally implemented to support the long-defunct oramod archive format.

The key benefits here are:

  • Removal of implicit and magic behaviours around mod.yaml, filesystems, and translations
  • Clean separation between installation and runtime (mods that ship all their own assets can now completely ignore the installation logic 🎉)
  • Another step towards upstreaming TDHD by allowing first-class support for mod-specific installation behaviours

@pchote pchote added this to the Next Release milestone Oct 15, 2024
PunkPun

This comment was marked as resolved.

@pchote

This comment was marked as resolved.

@PunkPun

This comment was marked as resolved.

@PunkPun

This comment was marked as resolved.

@pchote

pchote commented Oct 17, 2024

Copy link
Copy Markdown
Member Author

Fixed and rebased.

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • D2K detection of assets is wrong! While the quick install itself doesn't fail, the game fails to load and puts you back into the d2k-content mod. Note that with the installed files you are able to play on bleed, just not on this branch
  • after I install everything from remastered it is no longer detected
  • after installing required files from the remaster, I still have the option to quick install (no warning)

@pchote

pchote commented Oct 19, 2024

Copy link
Copy Markdown
Member Author

Rebased, fixed, and tested quick install + at least one advanced install method for all mods.

D2K detection of assets is wrong!

Oops, thats what I get for rushing things without proper testing.

after I install everything from remastered it is no longer detected

If you mean for RA, then this is expected because the remaster doesn't include the soviet briefings and therefore isn't a valid source for that content package.

after installing required files from the remaster, I still have the option to quick install (no warning)

This actually has always been the case, so i'd prefer to leave any changes to this to a different PR!

@PunkPun PunkPun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll want more thorough playtesting when playtest launch

@PunkPun
PunkPun merged commit b57be1c into OpenRA:bleed Oct 20, 2024
@pchote
pchote deleted the installer branch October 20, 2024 12:04
@PunkPun

PunkPun commented Oct 20, 2024

Copy link
Copy Markdown
Member

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants