Replace modcontent#21629
Merged
Merged
Conversation
Member
|
Windows packaging script fails with: macOS apps fail to run with: |
PunkPun
force-pushed
the
wip-packaging
branch
from
97b4d9c to
db86372
Compare
Member
|
Confirmed that Windows works with the new push. |
PunkPun
force-pushed
the
wip-packaging
branch
4 times, most recently
from
6cf9b79 to
f35d126
Compare
Member
|
Confirmed that macOS works with the latest push. I don't have an intel based linux machine to hand for testing the appimages. |
Member
Author
|
https://github.com/PunkPun/OpenRA/releases/tag/devtest-20241021 I tested on intel |
PunkPun
force-pushed
the
wip-packaging
branch
from
f35d126 to
3f61557
Compare
PunkPun
force-pushed
the
wip-packaging
branch
from
3f61557 to
3cf5a50
Compare
ottelo9
added a commit
to ottelo9/OpenRA
that referenced
this pull request
Oct 23, 2024
|
Thx for the fix. |
Contributor
|
Fixes #21628, I can confirm. I tried adding this as a patch to the package and it causes it to build successfully now. |
pchote
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly fixes #21628