Overhaul TD encyclopedia UI#21631
Conversation
dragunoff
left a comment
dragunoff
left a comment
There was a problem hiding this comment.
LGTM overall, nice work 👍 I left some minor comments.
There was a problem hiding this comment.
There is now a noticeable delay when accessing the encyclopedia for the first time (I assume as this file gets loaded). It's not a blocker but we may think about some sort of lazy loading as this is not a critical asset. Or maybe preloading when the user hovers over the button.
There was a problem hiding this comment.
UI artwork is loaded on demand, so the simplest workaround here would be to split the portraits over several smaller images. Although this means that they couldn't all live in the same collection, which complicates the plumbing... I'll have a think about this.
There was a problem hiding this comment.
Another option would be to bypass the regular UI and atlasing system completely and load the portraits as individual png files directly.
There was a problem hiding this comment.
With the images split the opening of the encyclopedia is now instant.
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
Ingame it looks awesome. Some entires will need their descriptions have their newlines fixed up, but that's out of scope
Indeed. I also want to add entries for the missing support units (a10, c17, boat, lst, mhq) and adjust the wording on the tech structures. These can be done in a followup PR. |
|
I've pushed a commit to test the performance improvement from splitting out individual portraits. @dragunoff can you please comment on whether this helps with the panel open time (my SSD is too fast to properly test 😞) |
pchote
force-pushed
the
td-encyclopedia-rework
branch
from
5e70960 to
47b039a
Compare
pchote
force-pushed
the
td-encyclopedia-rework
branch
from
47b039a to
cd59d06
Compare
|
Updated and ready for rereview. |
pchote
force-pushed
the
td-encyclopedia-rework
branch
from
cd59d06 to
6282f23
Compare
|
Updated again to include appropriate faction colours on the previews. |
pchote
force-pushed
the
td-encyclopedia-rework
branch
from
6282f23 to
4d94c36
Compare
|
Fixed. |
3 participants
Closes #21625.
The headline change is the addition of large rendered portraits from (primarily) the original game manual.
The embedded jpgs were dumped from the manual shipped with the steam release: many of these were already the right size, they just needed their white/black points adjusting and then a small amount of cropping. The rest were at only half resolution and not quite wide enough: these were upscaled and some extra background added on one side of the image.
I manually recreated a few of these low resolution portraits (e.g. commando, buggy, bike) where the renders used by the manual were themselves available. Apache and Supply truck were created from RA renders. Obelisk was created from an ingame FMV.