Determine pixel-to-texel ratio for each sprite individually. #21634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes rendering artifacts when sprites are scaled > 1.
PunkPun
reviewed
Oct 30, 2024
| var hasBGRA = SDL.SDL_GL_ExtensionSupported("GL_EXT_texture_format_BGRA8888") == SDL.SDL_bool.SDL_TRUE; | ||
| if (Version.Contains(" ES") && hasBGRA && major >= 3) | ||
| var hasDerivatives = SDL.SDL_GL_ExtensionSupported("GL_OES_standard_derivatives") == SDL.SDL_bool.SDL_TRUE; | ||
| if (Version.Contains(" ES") && hasBGRA && hasDerivatives && major >= 3) |
Member
There was a problem hiding this comment.
does OpenRA even run on OpenGL ES?
Member
Author
There was a problem hiding this comment.
yes, and this is actually the default on Windows (ANGLE provides a GLES implementation built on top of Direct X).
Member
Author
There was a problem hiding this comment.
I've tested that the GLES changes work correctly on both Linux (native) and Windows (ANGLE).
PunkPun
approved these changes
Nov 3, 2024
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue mentioned in #21631 (comment). See #17424 (comment) for the original discussion - my version of the fix is correct for sprites rendered at 1:1 scale, but fails when we want to render them at a large magnification. We now have a mechanism to require GLES extensions which is now used also for the derivatives.
Testcase: Change
ActorPreviewWidget'sGetScalemethod to return10fand check the lobby colour picker.Before:
After:
