Skip to content

use appimagetool with non-glibc linux support - #21635

Merged
pchote merged 2 commits into
OpenRA:bleedfrom
Drsheppard01:bleed
Nov 1, 2024
Merged

use appimagetool with non-glibc linux support#21635
pchote merged 2 commits into
OpenRA:bleedfrom
Drsheppard01:bleed

Conversation

@Drsheppard01

@Drsheppard01 Drsheppard01 commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

use appimagetool with non-glibc linux support

@pchote

pchote commented Oct 31, 2024

Copy link
Copy Markdown
Member

From https://github.com/AppImage/appimagetool:

Unlike previous versions of this tool provided in the AppImageKit repository, this version downloads the latest AppImage runtime (which will become part of the AppImage) from https://github.com/AppImage/type2-runtime/releases.

and from https://github.com/AppImage/type2-runtime:

This repository builds a statically linked runtime for type-2 AppImages in a Alpine Linux chroot with musl libc.

Since the runtime is linked statically, libfuse2 is no longer required on the target system.

This is an important fix that allows our AppImages to finally again run by default (without requiring the user to know to install libfuse2 first) on modern distros. I have confirmed locally that this is indeed the case on a fresh x86_64 Ubuntu 24.04.

@pchote pchote left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also remove this now redundant line from the Linux packaging?
https://github.com/OpenRA/OpenRA/blob/bleed/.github/workflows/packaging.yml#L56

@pchote pchote added this to the Next Release milestone Oct 31, 2024
@Drsheppard01

Copy link
Copy Markdown
Contributor Author

Thanks Paul for quickly reply! I remove this line from packaging.yml

@pchote
pchote merged commit 42989c7 into OpenRA:bleed Nov 1, 2024
@pchote

pchote commented Nov 1, 2024

Copy link
Copy Markdown
Member

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/6ba918dc1f5d5adcffbc4d3267380e2001e727b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants