Refactor editor clipboard logic as blitting logic#21642
Merged
Conversation
- Refactors internal editor clipboard logic into reusable map contents "Blitting" functionality. - Fix actor processing being unnecessarily (cell) looped within CopySelectionContents (now CopyRegionContents). - Deduplicates largely repeated code. - Minor code simplifications and renames.
ashleynewson
marked this pull request as ready for review
November 13, 2024 01:47
RoosterDragon
approved these changes
Nov 13, 2024
RoosterDragon
left a comment
RoosterDragon
left a comment
Member
There was a problem hiding this comment.
Did some copy-paste testing in RA and TS. Worked fine with all the various toggles for what to copy. After doing a lot of operations was able to undo and redo parts of as well as the whole history stack and get the same output. This passing is TS gives me confidence it's working okay with isometric and height.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor with no expected user-visible changes. These changes have been split out from #21637 and are ultimately motivated by that work.