Style fixes (.NET 9 SDK) - #21643
Merged
Merged
Conversation
RoosterDragon
marked this pull request as draft
November 13, 2024 19:23
Member
Author
|
CI giving quite a few errors not surfacing on a local run :) Edit: Fixed! |
RoosterDragon
force-pushed
the
net9-style
branch
4 times, most recently
from
November 13, 2024 19:44
04c1a2f to
32926dd
Compare
RoosterDragon
marked this pull request as ready for review
November 13, 2024 19:53
penev92
reviewed
Nov 15, 2024
penev92
reviewed
Nov 15, 2024
Don't enforce all the rules yet, since we are still targeting .NET 6. Adjust cast to nullable in UnloadCargo.ChooseExitSubCell. Avoid this cast tripping up CA2021 on older NET SDK versions.
RoosterDragon
force-pushed
the
net9-style
branch
from
November 15, 2024 18:56
32926dd to
34eb692
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you're using the .NET 9 SDK that came out yesterday (or e.g. updated Visual Studio which ships it) then some of the style rules have been updated and trigger additional warnings locally. We can also except them to be flagged by CI if the runners move to .NET 9, even if we continue to specify .NET 6 or .NET 8 as the build target.
Fix these issues to improve the local dev experience for anybody using this SDK:
See also #21211